Diskerud is a free agent after playing out his contract with Rosenborg. He has nearly joined MLS twice before, first with the Portland Timbers and then with the Columbus Crew, but it didn't come to be either time. Part of Diskerud's hesitation to join MLS was the league's requirement that players sign contracts with MLS, not necessarily the club, but he appears to have gotten over that and NYCFC will use their top spot in the allocation order to grab him.
It is still unclear if Diskerud will be joining the team as a Designated Player or not. The club already has David Villa and Frank Lampard (supposedly) on board so they only have one more DP spot left.
As far as MLS clubs go, Diskerud couldn't have found a better home than NYCFC. There are a lot of questions about ownership, autonomy, commitment and stadium with the club, but they are led by one of MLS's best managers in Jason Kreis. He develops talent well and the pressing he expects from his midfield, as well as his possession-dominant beliefs are also prevalent in Jurgen Klinsmann's system so it will be a good place for Diskerud to be.
Diskerud has said repeatedly that he loves the U.S. and wants to live in the country. Now he'll get the chance, in the country's biggest market and with a club that is starting from scratch. It's hardly a safe landing spot because of the various unknowns the club presents, but the club also presents him with a lot of opportunity that he will try to make good as the 24-year-old continues to make a push for the U.S.' first team.